Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix Empty highlighted words field #20329

Merged
merged 1 commit into from
Feb 8, 2021
Merged

[FIX] Fix Empty highlighted words field #20329

merged 1 commit into from
Feb 8, 2021

Conversation

yash-rajpal
Copy link
Member

  • I have read the Contributing Guide
  • I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Able to Empty the highlighted text field in preferences

Issue(s)

fixes #20328

Steps to test or reproduce

Further comments

after-highlights
The spelling of highlights was wrong due to which error was coming

@yash-rajpal
Copy link
Member Author

@ggazzo @MartinSchoeler Please review. This is just a typo in a variable name, which gives error.

MartinSchoeler
MartinSchoeler approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@ggazzo ggazzo merged commit 4e93da4 into RocketChat:develop Feb 8, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] Unable to empty Highlighted words in Preferences
3 participants
@yash-rajpal @MartinSchoeler @ggazzo